search

Blockstream / esplora

Explorer for Bitcoin and Liquid
MIT License
988 stars 395 forks source link

Bech32m support #323

Closed Sjors closed 2 years ago

Sjors commented 3 years ago

Currently SegWit 1 (Taproot) addresses are displayed as bech32 rather than bech32m.

Example: https://explorer.bc-2.jp/tx/95c7feca5f9e31a06d6391fecbeb13280b3da97cf6135d19c18db282b86cac9e

The bech32m address tb1p74334dv2yy92x564xucd8x0rv6h2v65djj8j8mjg26fam204ud4qkuvean there is displayed as tb1p74334dv2yy92x564xucd8x0rv6h2v65djj8j8mjg26fam204ud4qrqu4c3. 

src/bitcoin-cli -signet validateaddress tb1p74334dv2yy92x564xucd8x0rv6h2v65djj8j8mjg26fam204ud4qrqu4c3
{
  "isvalid": false,
  "error": "Version 1+ witness address must use Bech32m checksum"
}
RCasatta commented 3 years ago

Come here to open this issue, I see esplora fork https://github.com/Blockstream/esplora/ is using rust-bitcoin 0.23 while to support bech32m I think it's needed 0.26.2

jaonoctus commented 3 years ago

looking forward for this solution

shesek commented 3 years ago

We have a branch with rust-bitcoin v0.27 that's undergoing QA and should be merged soon, iiuc bech32m should Just Work once that's in.

druonn commented 2 years ago

@shesek Is there new information about Esplora and taproot support?

shesek commented 2 years ago

@druonn the changes in the branch I mentioned were since merged and are now part of master.