search

Blockstream / green_android

Blockstream Green Wallet for Android
GNU General Public License v3.0
177 stars 74 forks source link

Upgrade gradlew wrapper scripts (./gradlew & ./gradlew.bat) #108

Closed emanuelb closed 2 years ago

emanuelb commented 3 years ago

Description

The ./gradlew & ./gradlew.bat files are old, the ./gradlew require bash dependency which is removed in newer version, gradle version in distributionUrl was updated in the past without updating the related gradle scripts.

Expected behaviour

newer versions of the scripts are used which avoid the bash dependency, future updates to gradle will include updates to scripts as well.

Additional info

running: ./gradlew wrapper --gradle-version 6.8.2 which is the command to upgrade the gradle wrapper: https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:upgrading_wrapper

will result in changes in both gradlew and gradlew.bat files.

the history of ./gradle/wrapper/gradle-wrapper.properties shows that the gradle version was updated several times, but in each update the related wrapper files wasn't updated, thus in the future it's also recommended to run the above command when upgrading the gradle version (as it's change the gradle version in distributionUrl as well) https://github.com/Blockstream/green_android/commits/master/gradle/wrapper/gradle-wrapper.properties

angelix commented 3 years ago

Hi @emanuelb, gradle wrapper scripts updated in 4b447d9ed41dd715df93e8ffb454472e8128b15f.