Call to analytics server with settings disbled and clearnet servers under tor

[Turtlecute33]

Description

While i open the wallet i can see 4 outgoing connection checking DNS logs:

countly.blockstream.com

deluge-green.blockstream.com

jadepin.blockstream.co

my electrum server under tor

I've the app under TOR (with invisibile pro and not the bundled one) and the analytics disabled so i shouldn't connect to deluge server.

Could be a good idea let users to don't connect to clearnet server becouse this lower the privacy (making a call to clearnet server under tor will use exit nodes that can de-anonymize the traffic)

Version

Green wallet 3.9.2 Android 13.0 Pixel 6 GrapheneOS No google play services installed

[domegabri]

When you use the bundled Tor in Green, the app points to hidden services that we run for Tor users. When using a system-wide Tor as a VPN, you need to:

• Enable Tor
• Enable proxy and set to 127.0.0.1:9050

This tells the app you are using an external Tor and will connect to hidden services.

[licaon-kter]

What should the Tor explanation have to do with connections to countly.blockstream.com before the user set up anything?

Think this warrants a NonFreeNet antifeature in F-Droid :(

[licaon-kter]

I've added antifeatures to F-Droid as needed, hope this gets fixed in the next version

ref: https://gitlab.com/fdroid/fdroiddata/-/commit/449ae11dceca5adee1c905d7fa6cad100522cde1

[angelix]

I've added antifeatures to F-Droid as needed, hope this gets fixed in the next version

ref: https://gitlab.com/fdroid/fdroiddata/-/commit/449ae11dceca5adee1c905d7fa6cad100522cde1

I can work on that in 4.0.22.

Analytics collection is turned off by default, user has to explicitly consent before enabling it. countly.blockstream.com is also used to get Remote Config data like announcements, etc.

[angelix]

Partially fixed in 9542a791d77a38a81260eab7eb353f19ec4eb323.

A no-op countly class is provided for F-Droid flavor.

@licaon-kter please remove NonFreeNet and update the build script to pick the fdroid specific flavor eg. assembleProductionFDroidRelease. production flavor is the same as fdroid until the transition is made.

[licaon-kter]

@angelix great, ping us when ready to tag a new version :)

[angelix]

@angelix great, ping us when ready to tag a new version :)

@licaon-kter New release_4.0.22 just tagged.

[licaon-kter]

testing, brb

[licaon-kter]

...
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - not found
CMake Error at /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Threads (missing: Threads_FOUND)
Call Stack (most recent call first):
  /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.25/Modules/FindThreads.cmake:228 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:862 (find_package)

from cmake fail log

ld: error: unable to find library -lpthreads
clang: error: linker command failed with exit code 1 (use -v to see invocation)

which dep am I missing?

[angelix]

clang: error: linker command failed with exit code 1 (use -v to see invocation)

We didn't update GDK from last version, so your build environment seems different. Probably pthreads are missing from your env. (???)

[licaon-kter]

Which dep exactly?

Environment is kinda set in stone, so if you say "you had pthreads before because it compiled before" that would be at least false :)

[angelix]

Which dep exactly?

Environment is kinda set in stone, so if you say "you had pthreads before because it compiled before" that would be at least false :)

Looking into it. Can you share the full logs?

[licaon-kter]

full log: com.greenaddress.greenbits_android_wallet_22000422.log.gz

[angelix]

@licaon-kter Fixed in 9542a791d77a38a81260eab7eb353f19ec4eb323, please remove antifeature flags.

No-op Countly class is used for FDroid flavor.