search

Blockstream / green_android

Blockstream Green Wallet for Android
GNU General Public License v3.0
177 stars 74 forks source link

f-droid build system: updating steps to build gdk java bindings for a… #167

Closed lightyear15 closed 1 year ago

lightyear15 commented 1 year ago

…ndroid from scratch

rather than fixing tools/build.sh, let's use bare cmake calls and expose the internals of gdk's build-system. is cmake any less worth than make? of course not, so the same way we are used to make make install why not getting used to calling cmake :)

WARNING:

I am not sure if the image where f-droid build happens has cmake installed, if not, then we must add it

jgriffiths commented 1 year ago

You have to fix build.sh, since 3rd parties may need the java wrapper.

I am strongly against the current divergence of build commands for gdk. There should be one clearly documented way of building gdk and that should be used by our apps and well as the gdk/our internal CI's.

That one command can move to cmake and be documented when everything does, until then please do not fragment the build space any further.

let's ... expose the internals of gdk's build-system

Lets categorically not do this please.

lightyear15 commented 1 year ago

You have to fix build.sh, since 3rd parties may need the java wrapper.

I am strongly against the current divergence of build commands for gdk. There should be one clearly documented way of building gdk and that should be used by our apps and well as the gdk/our internal CI's.

That one command can move to cmake and be documented when everything does, until then please do not fragment the build space any further.

let's ... expose the internals of gdk's build-system

Lets categorically not do this please.

agreed you know that, I personallu would lean towards making use of cmake directly, I am not entirely sure you agree with such choice. Nevertheless, whether we keep build.sh or we migrate to cmake, the change should happen all at once, README include :+1: