search

Blockstream / green_android

Blockstream Green Wallet for Android
GNU General Public License v3.0
177 stars 74 forks source link

fix: convert text size unit sp to dp #168

Closed ChrisCho-H closed 1 year ago

ChrisCho-H commented 1 year ago

As a user of green in android, I just found out this app does allow font scaling(of user setting) but is not designed to fit with other components. I found out some of the textSize unit are dp, and the other sp. I don't see the intention of using sp which allows font scaling, so I converted all the sp unit to dp to fix this bug(it happens almost for all the screens). image

angelix commented 1 year ago

@ChrisCho-H Thank you for your PR. I made some changes, rebased it and merged it in https://github.com/Blockstream/green_android/commit/e3be853e9f746b9545b88667f5e107ae98960571