search

Blockstream / green_android

Blockstream Green Wallet for Android
GNU General Public License v3.0
198 stars 82 forks source link

Terms and policies are not links in all locales #181

Closed licaon-kter closed 9 months ago

licaon-kter commented 11 months ago

...currently it's just an odd checkbox that doesn't seem to mean anything

angelix commented 11 months ago

You mean this checkbox?

licaon-kter commented 11 months ago

No, this checkbox:

3b22d5bc_x7Z6kimORX-A06f9wBcYSw

PS: I don't use your locale

angelix commented 11 months ago

No, this checkbox:

3b22d5bc_x7Z6kimORX-A06f9wBcYSw

PS: I don't use your locale

It's a translation issue.

Is that correct "Sunt de acord cu Condiții de utilizare și Politică de Confidențialitate"?

licaon-kter commented 11 months ago

no, please look at the colours... read issue title again :)

angelix commented 11 months ago

no, please look at the colours... read issue title again :)

We do a search and replace, so all links in I agree to the Terms of Service and Privacy Policy like Terms of Service & Privacy Policy should be localized.

So adding the Romanian translation will fix the issue.

licaon-kter commented 11 months ago

So adding the Romanian translation will fix the issue.

Yeah, but do a add a fallback to English if the translated ones are not yet available

angelix commented 11 months ago

So adding the Romanian translation will fix the issue.

Yeah, but do a add a fallback to English if the translated ones are not yet available

The current approach has some limitations, until we do a refactor, this is the only solution.

Current approach works only if all or none of the strings used are translated. If some are translated and some are not, the replacement breaks.

angelix commented 9 months ago

Fixed in 4cd29f9cd1444b2f63738eebdc2ed6835153411a