Blockstream / green_android

Blockstream Green Wallet for Android
GNU General Public License v3.0
198 stars 82 forks source link

Green + Jade + Lightning -> Cannot add LN account without "paper hack" (Samsung S10e) #190

Closed Donach closed 8 months ago

Donach commented 10 months ago

Description

When trying to add "Create new account" in Green via Jade to add "Lightning Account", the QR code displayed has no white edges. This results in Jade never being able to properly scan the initial QR code to export the derived key for Green to use for the Lightning account.

Version

Green v4.0.22; Jade FW version 1.0.26

Steps to reproduce

  1. Open Green
  2. Unlock Jade in "Hardware Devices" wallet
  3. Click 3 dots -> Create New Account
  4. Select Lightning
  5. Try to scan QR code with Jade
  6. Fail

Expected behaviour

The QR code should have white edges so it's scannable with Jade.

Actual behaviour

QR code is impossible to scan. Hack I used for it to work, was laying white paper all around the QR code, which then works just fine.

Screenshots

photo_2024-01-05_12-07-55

Device or machine

Samsung S10e, Android, Jade v1.0.26, Green v4.0.22

Additional info

After using my "paper hack", I was able to export the key to the Green wallet and use the Lightning as expected.

angelix commented 10 months ago

Hi @Donach, thanks for reporting.

By looking at your photo, i can tell that something is wrong. Either you have an accessibility setting turned on or something else messes with the app's color. Could you please provide a photo or screenshot that shows the entire app interface? This will help us in diagnosing the problem more effectively.

You should expect to see a similar screen:

Donach commented 10 months ago

Hello! Forgot to add I'm using Dark Theme in my system. Funily though, other QR codes, like BTC receive address is rendered jsut fine with the white edge around the QR code. I can post the screen later on - on your screen I can clearly see the white edge there, it's missing on mine...

angelix commented 10 months ago

Hello! Forgot to add I'm using Dark Theme in my system. Funily though, other QR codes, like BTC receive address is rendered jsut fine with the white edge around the QR code. I can post the screen later on - on your screen I can clearly see the white edge there, it's missing on mine...

Donach commented 10 months ago

Hello! Forgot to add I'm using Dark Theme in my system. Funily though, other QR codes, like BTC receive address is rendered jsut fine with the white edge around the QR code. I can post the screen later on - on your screen I can clearly see the white edge there, it's missing on mine...

* Is this issue also occurring with the QR code on the receive screen?

* Is `Override force-dark` setting in Android enabled?

Yes, LN invoice looks 100% correct. No, I have 'force darkmode' set to OFF.

Donach commented 10 months ago

Hello! Forgot to add I'm using Dark Theme in my system. Funily though, other QR codes, like BTC receive address is rendered jsut fine with the white edge around the QR code. I can post the screen later on - on your screen I can clearly see the white edge there, it's missing on mine...

* Is this issue also occurring with the QR code on the receive screen?

* Is `Override force-dark` setting in Android enabled?

Yes, LN invoice looks 100% correct. No, I have 'force darkmode' set to OFF.

Ok just tested with Dark Mode OFF, and it did'nt solve anything for me. Might be some combination of either the device (S10e), or the system version/OneUI from Samsung (v12 Android, 4.1 OneUI). Here's how it looks. Screenshot_20240106_140608_Green

angelix commented 8 months ago

@Donach Can you please confirm the issue is fixed with the latest version?

Donach commented 8 months ago

Hello, sadly I can't , I don't have the Samsung s10e anymore... works fine on my Pixel 7a now...