search

Blockstream / green_android

Blockstream Green Wallet for Android
GNU General Public License v3.0
177 stars 74 forks source link

Message signing not working for Liquid Addresses #192

Closed Czino closed 4 months ago

Czino commented 5 months ago

Description

Message signing is often required when buying Bitcoin within the EU. I found that it works for bitcoin addresses, however, when choosing a liquid address, nothing happens when clicking on Sign Message

Version

4.0.22

Steps to reproduce

  1. click Receive
  2. select Liquid Bitcoin
  3. click More Options
  4. click List of Addresses
  5. click on sign icon for an address
  6. type any message to be signed
  7. click Sign Message

  8. Expected behaviour

Signature is presented

Actual behaviour

Literally nothing happens, no feedback, no error message.

Screenshots

image

Device or machine

Android 11

domegabri commented 5 months ago

this is a bug in the UI: signing addresses in liquid is not supported

Czino commented 5 months ago

I agree that it should not be accessible if not supported.

But I would also like to suggest to add BIP322 support.

angelix commented 4 months ago

Close in favor of #195