search

Blockstream / green_android

Blockstream Green Wallet for Android
GNU General Public License v3.0
198 stars 82 forks source link

Authentication Required to Change Denomination of Watch-Only Wallet #194

Closed noeljbass closed 8 months ago

noeljbass commented 9 months ago

-Unable to change basic denomination from BTC to sats on watch only wallet

-Cannot change wallet name successfully either, i suspect because of the same auth issue

jgriffiths commented 9 months ago

Hi,

All wallet metadata such as account names and transaction notes can only be changed by a full (non-watch-only) session. This is by design - if your watch-only details are leaked/obtained by an attacker, they are not able to grief you by deleting or altering this data.

The currency and pricing source settings are currently also only able to be changed by a full (non-watch-only) session. This is because fiat pricing limits are denominated in the wallets chosen currency. However, we will be allowing watch-only sessions to locally override these settings for display purposes in the next gdk (https://github.com/Blockstream/gdk) release 0.70.1, due in a few weeks. The wallet apps should support this functionality in their next release after that.

angelix commented 8 months ago

Fixed in 8511d1ae496470f96b6b6105ddeca015bdd3aa9b cc @noeljbass