search

Blockstream / green_ios

Blockstream Green Wallet for iOS
GNU General Public License v3.0
124 stars 33 forks source link

Add .ipa file to github releases #34

Open emanuelb opened 3 years ago

emanuelb commented 3 years ago

Add the .ipa file uploaded to apple store for the matched version to github releases as additional asset. https://github.com/Blockstream/green_ios/releases/tag/release_3.5.3

lvaccaro commented 3 years ago

Hi @emanuelb , the latest gaios.ipa (release_3.5.5) is a 145MB file and GitHub has a strict file limit of 100MB.

emanuelb commented 3 years ago

This issue is part of improving/researching reproducible-builds on ios, see this comment for more details to understand why it's needed: https://gitlab.com/walletscrutiny/walletScrutinyCom/-/issues/149#note_537109159

Green is already reproducible on Android in GooglePlay & F-Droid: https://gitlab.com/walletscrutiny/walletScrutinyCom/-/issues/159 The question is what about IOS? Can you upload the file to other place? (also it's better to ensure it not contain sensitive data, even if it's probably don't)

flosschamp commented 3 years ago

GitHub has a strict file limit of 100MB

@lvaccaro The 100MB limit refers to in-version-control pushes. You must use Git LFS for files like that.

However, Release files are 2GB.

We don't limit the total size of the binary files in the release or the bandwidth used to deliver them. However, each individual file must be smaller than 2 GB.