search

Blockstream / green_qt

Blockstream Green App
GNU General Public License v3.0
195 stars 32 forks source link

docker build: move packages in base image #15

Closed 0xmichalis closed 4 years ago

0xmichalis commented 4 years ago

Move any dependencies installed during build-time into the base image, otherwise you are missing out one of the main advantages offered by layering docker images properly which is fast build times.

greenaddress commented 4 years ago

@kargakis those things are already in the base image. The file is executed in the base image https://github.com/Blockstream/green_qt/blob/master/Dockerfile#L3 used by travis/gitlab.

The problem we have is that building Qt, gdk and all the deps is fairly slow so we may have to move those too as currently travis timesout.

0xmichalis commented 4 years ago

@greenaddress do you have a different image where the wallet gets installed?

greenaddress commented 4 years ago

@kargakis we updated the docker image to contain the other dependencies. Closing. Feel free to reopen if needed.