This adds a job to the CI that checks every rust file that is changed by the PR for formatting. It will however not fail the CI (continue-on-error: true) and still result in a green check mark.
We could add check-rustfmt as a prerequisite to check-self if we want to run it locally and fail the CI if the formatter complains on changed files
cdecker
commented
1 year ago
This adds a job to the CI that checks every rust file that is changed by the PR for formatting. It will however not fail the CI (
continue-on-error: true) and still result in a green check mark.We could add
check-rustfmtas a prerequisite tocheck-selfif we want to run it locally and fail the CI if the formatter complains on changed filesAnother option would be to use something like https://github.com/marketplace/actions/continue-on-error-comment to write a comment into the PR about formatting issues. That would not be as aggressive as to fail the CI or to enforce local checks.
Tell me what you think about this!