search

Blockstream / greenlight

Build apps using self-custodial lightning nodes in the cloud
https://blockstream.github.io/greenlight/getting-started/
MIT License
110 stars 28 forks source link

Re-use and re-export lightning-invoice crate #353

Closed ok300 closed 7 months ago

ok300 commented 7 months ago

This PR does two things:

First, re-uses the lightning-invoice crate. This helps get rid of possible duplicate versions of this dependency.

Second, it re-exports it, such that other projects using gl_client can simply use gl_client::lightning_invoice, so they don't have to risk dealing with duplicate versions either.

cdecker commented 7 months ago

ACK https://github.com/Blockstream/greenlight/pull/353/commits/80ea01fbc579a142068868fc34ab10bb8b58e4bd

ok300 commented 7 months ago

Rebased on main to fix conflicts.

cdecker commented 7 months ago

ACK https://github.com/Blockstream/greenlight/pull/353/commits/9bcaf600d98a8edf325390b198869f3c8e48c7c5

cdecker commented 7 months ago

Rebased, and will merge asap