search

Blockstream / greenlight

Build apps using self-custodial lightning nodes in the cloud
https://blockstream.github.io/greenlight/getting-started/
MIT License
109 stars 27 forks source link

track: Issues starting the signer after signer upgrade #363

Closed cdecker closed 5 months ago

cdecker commented 6 months ago

Some users have reported an issue where the signer would be missing a piece of information it was expecting. The signers suddenly expecting a new field suggests that the node had been initialized with a prior version (pre-0.11), opened a channel, and then upgraded the signer to post-0.11.

cdecker commented 6 months ago

@devrandom, do you know which field might be the missing one here? I'm looking to find a backtrace that should tell us.

The solution is probably to make the retrieval backfill a default value if not set, or allow continuing without the value for the specific channel in case there is no good default value.

devrandom commented 6 months ago

there are no attachments to this issue - which field or code location are affected? or if you can provide logs, that would be ideal

cdecker commented 6 months ago

Sadly I have not, but I will keep my eyes open for a sample. In the meantime would it make sense to create a repro test that can take an older version of VLS and then switch to a newer one and see if it can resume normally?

devrandom commented 6 months ago

we have a unit test for this, and we have upgraded all of our personal nodes lately.

cdecker commented 6 months ago

Perfect, we did deploy v0.11.0-rc.1 for a while which may have temporarily had this regression, we'll make sure to include the signer version should we find another occurrence.