search

Blockstream / greenlight

Build apps using self-custodial lightning nodes in the cloud
https://blockstream.github.io/greenlight/getting-started/
MIT License
109 stars 27 forks source link

Drop support for npn_protocols #385

Closed ErikDeSmedt closed 5 months ago

ErikDeSmedt commented 5 months ago

set_npn_protocols has been removed in python 3.11.

We are already using set_alpn_protocols so I think we can drop it safely.

This should help us to run gl-testing in standalone mode

cdecker commented 5 months ago

The package claims support for versions 3.8 onwards, does this affect versions earlier than 3.11? If yes, we might want to adjust that support or leave this jn for now.

ErikDeSmedt commented 5 months ago

According to this issue the functionality broke in python3.10 which is the same release in which it was deprecated.

To my understanding our code only works in python3.8 and python3.9.

I don't understand why we would want to keep npn in gl-testing. We only have a single client which isgl-client and that client does support apln.

cdecker commented 5 months ago

The only reason we have the npn mode in there was that earlier versions of grpc may use it. If I remember correctly this was required to get other clients talking to the mock grpc services. Then again, you're right, we don't have any other clients really.