Blockstream / greenlight

Build apps using self-custodial lightning nodes in the cloud
https://blockstream.github.io/greenlight/getting-started/
MIT License
109 stars 27 forks source link

py: Remove the pin to pyln-testing and pyln-client #389

Closed cdecker closed 2 days ago

cdecker commented 5 months ago

There is a change in the API between v23.11 and v24.02, causing gl-testing to fail. @Randy808 temporarily pinned them to the latest working version, but we should re-establish compatibility with the latest version asap.

ErikDeSmedt commented 5 months ago

I'll take this one

ErikDeSmedt commented 5 months ago

For pyln-testing the problem is situated in the --developer-flag which was introduced in v23.11. In this release the --developer-flag was introduced as a replacement for compile-time options.

It breaks pyln-testing when using pre-v23.11 versions of Core Lightning. Pre-v23.11-nodes will stop with an error-message indicating the --developer flag is not supported.

nepet commented 2 days ago

I'll close this for now as the original problem seems to be resolved -> gl-testing uses: