Blockstream / greenlight

Build apps using self-custodial lightning nodes in the cloud
https://blockstream.github.io/greenlight/getting-started/
MIT License
109 stars 27 forks source link

Use directory fixture from `pyln` #391

Closed ErikDeSmedt closed 5 months ago

ErikDeSmedt commented 5 months ago

Makes debugging easier

  1. Data from fixtures using pyln and gl-testing will appear in single folder
  2. All directories stay intact after failing test
cdecker commented 5 months ago

Nice :+1: Ideally we'd upstream usability changes like these, especially because they have the same name, and while not a problem in this case because Path and str are almost interchangeable, we generally don't want to have behavior differences between gl-testing and pyln-testing.

ACK https://github.com/Blockstream/greenlight/pull/391/commits/f660e758a58054974b9843d5b13c51e2eab97090