search

Blockstream / greenlight

Build apps using self-custodial lightning nodes in the cloud
https://blockstream.github.io/greenlight/getting-started/
MIT License
106 stars 28 forks source link

"Bitcoin" network when "Testnet" parameter used #441

Closed evd0kim closed 1 month ago

evd0kim commented 2 months ago

I noticed that my simple script (built using snippets on the documentation website) leads to "bitcoin" network get info, whereas the "testnet" argument is used in Signer and Scheduler.

I'm not sure if the node was initialized as "Bitcoin," but it should lead to an error message or exception anyway.

ErikDeSmedt commented 2 months ago

I think this issue is fixed in https://github.com/Blockstream/greenlight/pull/376/commits/9a081073eabc036681dacc49bc5465f9aa913b3d. It should be a part of the next release.

@Randy808 : Can you confirm this MR is a fix for the issue?

cdecker commented 2 months ago

Yes, it was mostly there as redundant information, and not used anywhere. The only time the network actually matters is on the Scheduler.register() call as that's the time the node gets allocated.

evd0kim commented 2 months ago

Yes, it was mostly there as redundant information, and not used anywhere.

Okay, thanks. I had a clue about that. I could indeed missed 'bitcoin' when registering new instance.