search

Blockstream / greenlight

Build apps using self-custodial lightning nodes in the cloud
https://blockstream.github.io/greenlight/getting-started/
MIT License
106 stars 28 forks source link

Upgrade to master crashes node. #464

Closed roeierez closed 3 weeks ago

roeierez commented 1 month ago

On first run when upgrading to master the node crashes. Seems like it is a result of signer upgrade.

cdecker commented 1 month ago

From what I can tell this is related to maybe_upgrade not completing before the node gets scheduled, causing the old version to be started, which doesn't match with the signer version, which then causes the crash. I'll dig into this further

roeierez commented 1 month ago

Thanks. Perhaps also worth also stopping the node right after maybe_upgrade (in case of real upgrade) because the node can be online at that time.

cdecker commented 1 month ago

Yep, that's the plan. Actually stopping would already be sufficient as it'd be immediately rescheduled by the client connecting 👍

cdecker commented 1 month ago

This has been merged and will be deployed on the server side tomorrow 👍

cdecker commented 3 weeks ago

Confirmed that this is no longer an issue.