Blockstream / greenlight

Build apps using self-custodial lightning nodes in the cloud
https://blockstream.github.io/greenlight/getting-started/
MIT License
109 stars 27 forks source link

signer: Capture signer rejections and report them #483

Closed cdecker closed 1 month ago

cdecker commented 1 month ago

We want to capture policy signer rejections too, as they can help us identify problems for false negatives, and can be used to fine-tune policies, or act as a regression test suite should the rejection be a true positive.

Sadly we were not actually sending a rejection, due to a misplaces ? that'd bubble up the error past the reporting spot. This PR addresses that by handling the response in a more fine-grained manner.