search

Blockstream / greenlight

Build apps using self-custodial lightning nodes in the cloud
https://blockstream.github.io/greenlight/getting-started/
MIT License
117 stars 27 forks source link

plugin: Do not pass signer store persistence error to the client #495

Closed cdecker closed 3 months ago

cdecker commented 3 months ago

The client is disconnecting right away, then reconnecting, and retrying the same request over and over again. That's not correct, and we should stay connected, but not return the signer response if we could not persist the associated signer state. This is equivalent to before, the signer state version collision still happens, but the client doesn't enter the busy loop.

cdecker commented 3 months ago

I expect this to paper over issue https://github.com/Blockstream/greenlight/issues/494 to some degree, as the client doesn't go quite as crazy, but we still have full visibility into occurrences because the error originates on our servers. We'll continue to hunt the issue, but this should alleviate some of the symptoms.