BlockstreamResearch / codex32

A paper computer for Shamir's Secret Sharing over the Bech32 alphabet.
80 stars 23 forks source link

General suggestions for BIP cleanup #39

Closed robot-dreams closed 2 years ago

apoelstra commented 2 years ago

This looks great to me! I think @roconnor-blockstream may take issue with the "such as" language in the first paragraph, since I think this scheme is supposed to be used specifically with BIP-32 seeds.

robot-dreams commented 2 years ago

@apoelstra sounds good, updated to make it clear it's specifically for BIP-32

Added a bit more copy editing. One thing to note, previous we had this terminology:

I think this could cause some confusion—in the PR I renamed the last thing to payload instead, but LMK if you prefer a different name.

apoelstra commented 2 years ago

Thanks, this all looks great to me!