search

BlockstreamResearch / rust-secp256k1-zkp

Creative Commons Zero v1.0 Universal
31 stars 37 forks source link

Prepare for -sys release 0.5.0 #42

Closed jonasnick closed 2 years ago

jonasnick commented 2 years ago

I messed up #41 by forgetting to also bump -sys.

jonasnick commented 2 years ago

Fwiw I also tried to update the vendored secp-zkp library, but that results in test failure which under valgrind shows that something is going very wrong memory wise and valgrind is pointing to something being wrong with the context. My hypothesis is that the preallocated context size changed in secp-zkp, but since we're reusing the Context from rust-secp, which is behind in C-libsecp the Context doesn't have the updated preallocated context size.

Tibo-lg commented 2 years ago

Just trying to be useful, but I can confirm that tests fail with latest secp-zkp. And I get the exact same result using the previously used commit (f3708a1ecb445b1b05a0f8fcd1da6a88f83d89c4).

apoelstra commented 2 years ago

We can update the library in rust-secp to match rust-secp-zkp since we are about to do a major release anyway.

@jonasnick suggested to me in another channel that he was working on this, so I'll leave that to him.

thomaseizinger commented 2 years ago

@jonasnick Any chance we can get a release out without the changes to the vendored C library? I would like to get rid of Git dependencies :)