nits from `cargo test` and `cargo clippy` on latest nightly

BlockstreamResearch / rust-secp256k1-zkp

Creative Commons Zero v1.0 Universal

31 stars 36 forks source link

nits from `cargo test` and `cargo clippy` on latest nightly #65

Closed apoelstra closed 1 year ago

apoelstra commented 1 year ago

The newest nightly has a new "unused mut" warning which is causing CI to fail. Fix that, and while we're at it, run clippy. And while we're at that, remove some #[deny] conditions from the crate root since these properly belong in CI (via -D warnings) rather than in the source.

apoelstra commented 1 year ago

cc @sanket1729 could you take a look at this?

sanket1729 commented 1 year ago

LGTM, will ACK after #54 is in.

apoelstra commented 1 year ago

Ok, rebased and should be good to go. This redoes a bit of the "add doccomments to re-exports" word but I think it does a better job, so I kept the new version.