BlockstreamResearch / rust-simplicity

Creative Commons Zero v1.0 Universal
58 stars 12 forks source link

ci: add windows/macos to clippy to reproduce compilation error on windows #187

Closed delta1 closed 8 months ago

delta1 commented 9 months ago

this PR adds windows and macos to the clippy job to reproduce the compilation failure in #186

also fixes some clippy warns/errs

delta1 commented 9 months ago

I will remove the clippy commit

delta1 commented 9 months ago

closing for https://github.com/BlockstreamResearch/simplicity/pull/211

delta1 commented 8 months ago

Is it worth having this change in CI to check macos/windows compilation?

delta1 commented 8 months ago

rebased

uncomputable commented 8 months ago

Depends on #191. Let's merge this PR once CI runs.

uncomputable commented 8 months ago

@delta1 Feel free to rebase

delta1 commented 8 months ago

@uncomputable rebased. windows ci failure is fixed upstream and in #192

uncomputable commented 8 months ago

Let's rebase on top of the merged #192 to fix CI.

delta1 commented 8 months ago

@uncomputable done. macos failure looks spurious

apoelstra commented 8 months ago

@uncomputable this crate currently doesn't build with the elements feature and apparently our CI doesn't check this. It was broken in #189.

I can't run my local CI, or even cargo test, until this is fixed.

uncomputable commented 8 months ago

@apoelstra I thought our CI would catch this, but apparently it doesn't. master doesn't build on my machine :/

Let's fix master in a separate PR.