Closed delta1 closed 8 months ago
I will remove the clippy commit
Is it worth having this change in CI to check macos/windows compilation?
rebased
Depends on #191. Let's merge this PR once CI runs.
@delta1 Feel free to rebase
@uncomputable rebased. windows ci failure is fixed upstream and in #192
Let's rebase on top of the merged #192 to fix CI.
@uncomputable done. macos failure looks spurious
@uncomputable this crate currently doesn't build with the elements
feature and apparently our CI doesn't check this. It was broken in #189.
I can't run my local CI, or even cargo test
, until this is fixed.
@apoelstra I thought our CI would catch this, but apparently it doesn't. master
doesn't build on my machine :/
Let's fix master
in a separate PR.
this PR adds windows and macos to the clippy job to reproduce the compilation failure in #186
also fixes some clippy warns/errs