search

BlockstreamResearch / rust-simplicity

Creative Commons Zero v1.0 Universal
58 stars 12 forks source link

update rust-bitcoin to 0.31 #189

Closed RCasatta closed 9 months ago

RCasatta commented 10 months ago

Since elements-miniscript depends on rust-simplicity and keystone depends on both rust-elements and elements-miniscript we need this to try out https://github.com/ElementsProject/rust-elements/pull/188

Not mergeable yet, since it requires rust-elements release to remove the patch section

RCasatta commented 10 months ago

can't figure out how to reproduce the clippy issue locally...

RCasatta commented 10 months ago

Also, I am not sure how to solve the fuzz errors...

uncomputable commented 10 months ago

Depends on #191.

The clippy issue can be reproduced by running clippy --all-targets on the latest Rust version. I can't wait to nixify CI so our errors become more reproducible.

apoelstra commented 10 months ago

I can't wait to nixify CI so our errors become more reproducible.

Lol, when you find out what's involved in running clippy from Nix you'll wish you were still waiting.

RCasatta commented 10 months ago

Thanks @uncomputable that fixed the clippy issue.

RCasatta commented 10 months ago

latest force-push only updated the version of unreleased rust-elements.

fuzzing fixed thanks to secp256k1-zkp point release https://github.com/BlockstreamResearch/rust-secp256k1-zkp/pull/78

To be undrafted now needs only rust-elements release