Open real-or-random opened 7 months ago
I have a few nits that can be cleaned up in a separate PR. Your detailed and helpful comments in the main code and tests is very much appreciated. Nits: we may want to add a header to the include file that links to the BIP there's still a mention of aggsig_size we may want to move aggregate before inc_aggregate we should mention expected size of input aggsig array in_aggregate "Should be aggsig_len = 32*(n+1)" -> "Must be"
I have a few nits that can be cleaned up in a separate PR. Your detailed and helpful comments in the main code and tests is very much appreciated.
Nits:
aggregate
inc_aggregate
_aggregate
Originally posted by @jonasnick in https://github.com/BlockstreamResearch/secp256k1-zkp/pull/261#pullrequestreview-1907392455
Originally posted by @jonasnick in https://github.com/BlockstreamResearch/secp256k1-zkp/pull/261#pullrequestreview-1907392455