search

BlockstreamResearch / simplicity

Simplicity is a blockchain programming language designed as an alternative to Bitcoin script.
MIT License
305 stars 45 forks source link

Update invariant of rawTapEnv #232

Closed roconnor-blockstream closed 5 months ago

roconnor-blockstream commented 5 months ago

We need to explicitly state that scriptCMR must be 32 bytes.

This feedback came from @delta1.

apoelstra commented 5 months ago

Can you rebase this on master? Because you have been "merging" via rebase, this PR looks to my tooling like a 12-commit branch off of master even though 11 of those 12 commits have identical diffs to ones that are in master.

roconnor-blockstream commented 5 months ago

I cannot. Generally speaking, we will be PRing into 'staging' for the time being.

Can you not set 'staging' as your base branch in your tooling?

apoelstra commented 5 months ago

I cannot. Generally speaking, we will be PRing into 'staging' for the time being.

Oh, I'm an idiot. Yes, I can definitely use staging rather than master. I just had to notice the merge target of the PR I was reviewing..