BlockstreamResearch / simplicity

Simplicity is a blockchain programming language designed as an alternative to Bitcoin script.
MIT License
302 stars 45 forks source link

Separate witness data #235

Closed roconnor-blockstream closed 3 months ago

roconnor-blockstream commented 3 months ago

We will store witness data in a separate stack item.

Regression tests 1 and 2 used to test the prefix of the witness data which consisted of the length of the witness data. However that prefix no longer exists. Thus the tests have been removed.

roconnor-blockstream commented 3 months ago

I have a personal branch of elements that integrates this interface change, just to make sure it works. If you are interested you can find it at https://github.com/roconnor-blockstream/elements/tree/simplicity-staging.

I expect that https://github.com/uncomputable/asset-gen will need to be eventually reworked to work with this new interface to Simplicity.

roconnor-blockstream commented 3 months ago

I've address the comments.