Fix bindings to scale and linear_combination_1

BlockstreamResearch / simplicity

Simplicity is a blockchain programming language designed as an alternative to Bitcoin script.

MIT License

305 stars 45 forks source link

Fix bindings to scale and linear_combination_1 #245

Closed roconnor-blockstream closed 4 months ago

roconnor-blockstream commented 4 months ago

When the safe versions of these functions were introduced, the primitiveJetNode.inc file was not correctly updated to bind to the new "safe" version of the jets.

To remedy this issue we instead exchange the names of the safe functions, removing the safe prefix and instead adding an "offcurve" prefix to the unsafe versions.

primitiveJetNode.inc isn't touched in this commit since it was already referencing the names without a prefix.

roconnor-blockstream commented 4 months ago

This fixes an issue with #237.

uncomputable commented 4 months ago

@roconnor-blockstream Do you plan to update primitiveJetNode.inc to include off_curve_scale and off_curve_linear_combination1?

roconnor-blockstream commented 4 months ago

@roconnor-blockstream Do you plan to update primitiveJetNode.inc to include off_curve_scale and off_curve_linear_combination1?

Not until their code is verified correct.