BlockstreamResearch / simplicity

Simplicity is a blockchain programming language designed as an alternative to Bitcoin script.
MIT License
305 stars 45 forks source link

Msvc jets.c #260

Closed roconnor-blockstream closed 1 month ago

roconnor-blockstream commented 1 month ago

Renaming files to make MSVC happier, and renaming sources.mk at the same time to make it more clear that it is elements specific.

roconnor-blockstream commented 1 month ago

This renaming might require changes in rust-simplicity.

apoelstra commented 1 month ago

I don't think it will; we vendor only the contets of the C/ directory.

apoelstra commented 1 month ago

error: builder for '/nix/store/0gp4zpjxcpm4dqqik09idiqllbm03krj-Simplicity-0.0.0.drv' failed with exit code 1;
       last 10 log lines:
       > provides this library (you may need the "-dev" version). If the library is
       > already installed but in a non-standard location then you can use the flags
       > --extra-include-dirs= and --extra-lib-dirs= to specify where it is.If the
       > library file does exist, it may contain errors that are caught by the C
       > compiler at the preprocessing stage. In this case you can re-run configure
       > with the verbosity flag -v3 to see the error messages.
       > If the header file does exist, it may contain errors that are caught by the C
       > compiler at the preprocessing stage. In this case you can re-run configure
       > with the verbosity flag -v3 to see the error messages.
       >
       For full logs, run 'nix log /nix/store/0gp4zpjxcpm4dqqik09idiqllbm03krj-Simplicity-0.0.0.drv'.

Haskell derivation fails to build with this patch.

Also, if you are changing it anyway, I would suggest putting a - in the name.

roconnor-blockstream commented 1 month ago

... also this renaming might require changes in the haskell bindings.

roconnor-blockstream commented 1 month ago

I think it is fixed.

apoelstra commented 1 month ago

Oh, I see. Yeah, this likely will require changes in rust-simplicity.