BlockySurvival / issue-tracker

A non-code repo for tracking issues w/ the Blocky Survival minetest server
12 stars 0 forks source link

Take ownership of the travelnet mod #288

Closed oversword closed 2 years ago

oversword commented 3 years ago

The travelnet mod (https://github.com/Sokomine/travelnet) is pretty horrible and deserves a re-write for its indentation alone

The code should be formatted

The Notification about how to use should be changed

A new "TARDIS" travelnet should be added that can teleport to any place randomly

Lanhild commented 3 years ago

A new "TARDIS" travelnet should be added that can teleport to any place randomly

A command like /tprandom would be, I think, better and more practical to use. Though, it should not teleport into protected areas, and have a cooldown to use it.

Lanhild commented 3 years ago

Or instead of blocking teleporting into protected areas, a custom property added to areas could be done. Something similar to /area_flak

oversword commented 3 years ago

I would be happy to add that command but I think it'd be far more fun to have a TARDIS node, it would be able to teleport into protected areas but it'd be impossible to pick it up, and it would be uncraftable. There would be one on the server and the admins would each have a key they can use to call it to their location

Lanhild commented 3 years ago

I understand for the fun of the node. So it would be:

/tprand to teleport to the set location

oversword commented 3 years ago

Another thing: Travelnets could have multiple pages, lifting the connection limit

BuckarooBanzay commented 3 years ago

Another thing: Travelnets could have multiple pages, lifting the connection limit

We started to rewrite/improve it here: https://github.com/mt-mods/travelnet PR's, contributors and maintainers welcome 👍

oversword commented 3 years ago

@BuckarooBanzay

We started to rewrite/improve it here: https://github.com/mt-mods/travelnet PR's, contributors and maintainers welcome 👍

I literally just finished cleaning up the formatting myself, I'd probably rather redo it myself to be honest, I'm not sure everyone would want the features I do

fluxionary commented 3 years ago

@oversword not sure what your plans for features are, but i'd certainly jump at the chance to pick up all the bugfixes buckaroo has probably done. we could still fork, but maybe from his version.

oversword commented 3 years ago

@fluxionary plans for features are in this issue I probably should to be honest... I'm not currently aware of any bugs though Also looking at the diff I would still have to change every line to fix this damn formatting, it would be unmergable as soon as I make the first commit

fluxionary commented 3 years ago

ah. i wholeheartedly agree to fixing formatting if it's terrible :) i think i remember that from soko's mods, one of the reasons why i rarely stuck my head into them too deeply

oversword commented 2 years ago

Closed now we are using https://github.com/mt-mods/travelnet Will make a new issue for making a tardis mod