BlockySurvival / issue-tracker

A non-code repo for tracking issues w/ the Blocky Survival minetest server
12 stars 0 forks source link

cool_trees oak slabs are randomly turning into more_trees oak trunk slabs #308

Closed oversword closed 3 years ago

oversword commented 3 years ago

I replicated, but only the first time a slab was placed

I have no idea why this would happen, I suspect it may be to do with the stairs mod?

There are issues with slabs from this mod anyways, they are not crafted like other slabs or stairs, it's very weird

oversword commented 3 years ago

Can replicate:

The actual node name changes: this does not seem to be a purely visual bug

I have not yet been able to replicate this on local, trying a full BLS setup now

I suspect this is something to do with the fact the slabs are actually both oak trunk slabs even though the cool_trees ones have the texture of the planks - cool trees is just stoopid. However, I am certainly seeing the node name itself change, though not in a basic setup, so it's likely this is something on BLS being weird, like an alias

oversword commented 3 years ago

Can easily replicate this on a full bls setup, but not a minimal setup (cool_trees + moretrees + stairs + bls)

oversword commented 3 years ago

The issue is either in xdecor, or is something bls does when xdecor is enabled.

This minimal setup reproduces the issue:

load_mod_moreblocks = true
load_mod_oak = true
load_mod_moretrees = true
load_mod_bls = true
load_mod_biome_lib = true
load_mod_xdecor = true
load_mod_lib_chatcmdbuilder = true

When xdecor is disabled, the issue stops

oversword commented 3 years ago

in bls_custom/microblocks_cleanup.lua, line 248-266, we perform weird logic based on the return value from xdecor.stairs_valid_def, it seems this code is causing a peculiar aliasing effect that is not smart enough to figure out that the cool_trees and moretrees variations are different