search

Blocship / star_book

A digital diary and mood tracking app that helps you in keeping track of your mood and productivity throughout the month/year.
https://www.starbook.dev
MIT License
133 stars 108 forks source link

resolves #465 #491

Closed ayushsingh01042003 closed 9 months ago

ayushsingh01042003 commented 9 months ago

I made the suggested changes by modifying the PRIVACY.POLICY.md file of the repo and adding the contents from the link https://qurantalk.notion.site/Privacy-Policy-for-Starbook-Mobile-App-a8fb153c39dd45dfa5b2cb9a945e3c84?pvs=4 to it. Please let me know if this is correct.

AbdullahAhmedSoomro commented 9 months ago

Yes, it's correct but I mentioned you earlier in a previous Pull Request that you created, Please go through Contributing.md because your Pull request does not meet the requirements. Therefore I am closing this pull request too. Check how to name a branch for an issue.

ayushsingh01042003 commented 9 months ago

@AbdullahAhmedSoomro I was unable to find anything regarding how to name a branch in CONTRIBUTING.md so could you please tell me how do I name the branch and commit message for this Issue or let me know where the instructions are written for the same

AbdullahAhmedSoomro commented 9 months ago

I apologize for my mistake it was in Readme.md not in Contributing.md, here you can see, how to name the branch: image

ayushsingh01042003 commented 9 months ago

So shall i name it as feature/Privacy&Terms and commit as "Update Privacy&Policy.md" would that be good ?

AbdullahAhmedSoomro commented 9 months ago

Yup