AHQuick Search

[GoogleCodeExporter]

Make sure that the problem is indeed due to Fallen Sword Helper / Sigma
Storm Helper, by disabling Greasemonkey completely (by clicking on the
monkey icon) and refreshing, before submitting a defect.

Include any relevant output from Error Console (Tools > Error Console) that
is.

What steps will reproduce the problem? (One defect per issue, please)
1.
2.
3.

What is the expected output? What do you see instead? I expect to see my AH
Quick Search as I normally do. Instead, there is no links, and no box to
change the search. 

What version of the product are you using? On which version of Firefox?
Version 614. Firefox 3.0.

Please provide any additional information below.

Original issue reported on code.google.com by scout9...@gmail.com on 25 Feb 2009 at 2:45

[GoogleCodeExporter]

A Screenshot of the problem.

Original comment by scout9...@gmail.com on 25 Feb 2009 at 2:54

Attachments:

• quicksearch.jpg

[GoogleCodeExporter]

There are some errors in your customized AH quick search content (when you edit 
it).
A quick way to reset your AH quick search content is:
+ Type about:config in the address, press Enter
+ In the filter, type quickSearch
+ You should see
"greasemonkey.scriptvals.terrasoft.gr/FallenSwordHelper.quickSearchList", right 
click
on it and choose Reset

I know the problem and should be fixing it soon.

Developers: the content from the text box is not check for error, the
System.JSON_getValue is not wrapped in a try catch block.

Original comment by ipodsee...@gmail.com on 25 Feb 2009 at 3:47

• Changed state: Accepted
• Added labels: Game-FallenSword
• Removed labels: Game-All

[GoogleCodeExporter]

Wrapping stuff in try catch blocks is a bad idea. Only do that when you know 
exactly
how to handle the exception.

Original comment by GSchizas on 25 Feb 2009 at 8:37

[GoogleCodeExporter]

what I mean of the try catch block is to use in the saveAHQuickSearchList 
function
(not sure of the name), not in the System function.

try JSON.parse(user_input) catch (ex) {alert(error in input); return;}
continue normally here

so that user_input is tested before saving to JSON/GMvalue.

Original comment by ipodsee...@gmail.com on 26 Feb 2009 at 6:59

[GoogleCodeExporter]

A better idea would be to never allow the user to add JSON objects. This screen
should be more user friendly. Since quick search has already been changed, I'm
closing this issue as fixed (in r626)

Original comment by GSchizas on 28 Feb 2009 at 8:39

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by GSchizas on 28 Feb 2009 at 8:39