Bloggify / github-calendar

:bar_chart: Embed your GitHub calendar everywhere.
https://bloggify.github.io/github-calendar/example/
MIT License
1.22k stars 213 forks source link

Tooltips are not working (2.2.7) #136

Closed jxmot closed 2 years ago

jxmot commented 3 years ago

Hello,

I'm trying to get tooltips to work. I've looked through the PRs and issues and there appears to have been a "fix" made but that was in 2020.

I've examined the live demo code, and it is enabling tooltips but they do not work. I have also downloaded the latest (2.2.7) from the repo and it isn't working either.

To see this error, just go to the project demo page. So far it has not worked on Chrome, FireFox, and Opera.

Thanks!

secondl1ght commented 2 years ago

I have the same issue, I have enabled tooltips but nothing appears on mouse hover.

IonicaBizau commented 2 years ago

Hmm, they seem broken on the demo page too... Contributions are welcome!

pengfeiw commented 2 years ago

I create a pull request to fix this bug.

secondl1ght commented 2 years ago

Still not working for me, will it take a little bit of time to start working?

pengfeiw commented 2 years ago

Do you set the tooltips: true ? @secondl1ght

secondl1ght commented 2 years ago

Yes I had that enabled the whole time, I just left it like that even though they were not working. I refreshed my page, do I need to do anything else?

pengfeiw commented 2 years ago

The example has tooltips now, check you has updated the github-calendar package in your project. @secondl1ght

secondl1ght commented 2 years ago

Is it possible to have tooltips with just vanilla JS? I added the script tags but did not install anything with yarn or npm.

pengfeiw commented 2 years ago

The content of script is not the newest.

secondl1ght commented 2 years ago

So we need to update that or I can just paste the whole script in my code and make the change you just PR'ed?

secondl1ght commented 2 years ago

Update: Yep that worked, I just put the script right in my project and then updated it with the fix you just made in your PR. Thanks!

secondl1ght commented 2 years ago

One more thing if you are interested in doing more, when you hover of the 'Less More' boxes a tooltip appears with null but it should probably just not appear at all for those boxes. @pengfeiw

pengfeiw commented 2 years ago

Thanks for point that out. I'll fix it later.

pengfeiw commented 2 years ago

I have make a new pr to fix it. @secondl1ght