Contributions showing as text, not squares

Bloggify / github-calendar

:bar_chart: Embed your GitHub calendar everywhere.

https://bloggify.github.io/github-calendar/example/

MIT License

1.24k stars 213 forks source link

Contributions showing as text, not squares #169

Closed masterneko closed 8 months ago

masterneko commented 1 year ago

Hi,

This issue was first noticed on Tabliss which depends on github-calendar. The contributions should be grey/green squares but appear as text.

TriAttack238 commented 1 year ago

I have the same problem. Thought it might have been caused by my updating to Windows 11, but it seems to be a new issue.

polypoyo commented 1 year ago

Same issue here, also coming from Tabliss. Looks like it's coming from the hover text seen on the official page.

Anoerak commented 1 year ago

Same issue on Firefox, Edge and Safari.

sskartheekadivi commented 1 year ago

Same issue with Windows 10 + Google Chrome.

kelvinjou commented 1 year ago

Same issue. Macbook & Iphone + Opera & Chrome.

IonicaBizau commented 1 year ago

Hey all! Thanks for reporting this. I’m currently recovering after a knee surgery, so I’m afraid I am not going to be able to push a fix to this but I’m happy to accept a pull request. Sorry for the inconvenience… Sent from my iPhoneOn 16 Jul 2023, at 11:23, Anørak @.***> wrote: Same issue on Firefox, Edge and Safari.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>

Jwashton commented 1 year ago

I can't dig into it more right now, but to give somebody else a jump start:

It looks like this script fetches the information from this proxied location: https://api.bloggify.net/gh-calendar/?username=Jwashton

And it looks like the script is expecting that response to contain an SVG, but it now contains an HTML table.

This means that a couple different things go wrong: in the browser console I get a TypeError: svg is null and in the CSS some critical selectors don't match because they're looking for rect.class instead of td.class.

Here's one potential fix for the CSS issues from @polypoyo .

d-kleine commented 1 year ago

I hope that there will be a hotfix in this repository soon 🙏 🤞

IonicaBizau commented 8 months ago

Sorry for the delay on solving this. This is finally fixed. 🎉

d-kleine commented 8 months ago

@IonicaBizau Just want to be sure, at least for me it looks not to be fully fixed yet:

cells are colored, but no frame around each cells as before (see above)
counters seem to be broken too

Also, when minimized, the week day labels intersect with the cells:

In the minimized view, could you please also make the thumb element in horizontal scrollbar starting from the right side to show the latest contributions? Currently, the thumb starts from the left side, showing the latest contribs:

It would be better if the thumb could start from the right side, showing the most recent contribs:

Also, in dark mode setting in the browser, the global_stats labels stay black:

White mode:

Dark mode:

Please also see your example in action