Error on file page afte file deletion

[extragornax]

Hello,

Little php error / warning when deleting a file from another page and reloading. Procedure:

• Browse to the fichiers tab (admin/fichiers.php)
• Add a file
• Stay on the page after the upload and open another tab
• Browse to the same url (admin/fichiers.php)
• Delete a file from the second tab
• Reload the first one tab

`Notice: Undefined variable: files in /srv/http/blogotext/admin/fichiers.php on line 489

Warning: Invalid argument supplied for foreach() in /srv/http/blogotext/admin/fichiers.php on line 489`

The error is coming from the file existance loop

[remrem]

you working on it or I take a look ?

[extragornax]

You can take a look at it if you want, I'm trying to get why we use mebibytes instead of megabytes

[remrem]

Ok, I handle this. "mebibytes" ? Check your lang file ?

[extragornax]

@remrem Check this MiB are mebibytes in french it's the same

The word is based on $maxFileSize = format_size(min(return_bytes(ini_get('upload_max_filesize')), return_bytes(ini_get('post_max_size'))));

Should I post an issue about it ?

[remrem]

My bad, forget about this ... ;) You want to replace mebi by mega ?

[extragornax]

@remrem that's up to you, megabytes seem more logical though

[extragornax]

Adding an if statement to check if files exists seems to have fixed the issue. I'll push an editable PR soon @remrem

[remrem]

not really, mega is a prefixes (like kilo, giga...) from the SI wich means (x1000), but (every ?) OS use the binary prefixes (1024 and not 1000).
I think it's a better idea to keep the binary prefixes, it's less mindfuck than Mo, Mo, Mb, MB.
And you can take a look on the wikipedia article, seem's the right way to do.

[extragornax]

2MB and 2MiB are so similar in size anyway, not an issue

[extragornax]

PR #329

[remrem]

I think we can close this issue ?

[extragornax]

Fixed