search

Blondazz / KeyOverlay

A simple key overlay for osu! streaming
GNU General Public License v3.0
197 stars 28 forks source link

Circle CreateItems.cs #61

Closed jekser2 closed 1 year ago

jekser2 commented 1 year ago

Created a version of this key overlay to be shape a circle

As well ass added other stuff

Blondazz commented 1 year ago

Hello. This is cool but that PR overwrites my existing code and i cannot merge it into the repo like that. Please make a version that would have both of them. Also please put all of your changes in one pull request.

jekser2 commented 1 year ago

This is my first time doing a gut repo and im not a coder my self. I modified the code entirely to create a different version instead of merging but i cant get any of your contacts to create my own git repo. That was the goal not to create a merge sorry if it was confusing. This is my first time using github and making a contribution

On Fri, May 19, 2023, 4:56 PM Daniel @.***> wrote:

Hello. This is cool but that PR overwrites my existing code and i cannot merge it into the repo like that. Please make a version that would have both of them. Also please put all of your changes in one pull request.

— Reply to this email directly, view it on GitHub https://github.com/Blondazz/KeyOverlay/pull/61#issuecomment-1554326398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS77L2XUUGZQ2RXCB2CCSOLXG47WFANCNFSM6AAAAAAYCFAWF4 . You are receiving this because you authored the thread.Message ID: @.***>

Blondazz commented 1 year ago

I'm not sure if I understand, you already created your own repo by forking mine. And what do you mean by contacts?

jekser2 commented 1 year ago

Sorry if it's confusing. What i mean by contact is, how do i msg the owner of this repo. Because i would like to create my own repository with this version i created instead of actually forking to the original repo. Like friedchicken repo. Hope this clear some things up.

On Wed, May 24, 2023, 3:55 PM Daniel @.***> wrote:

I'm not sure if I understand, you already created your own repo by forking mine. And what do you mean by contacts?

— Reply to this email directly, view it on GitHub https://github.com/Blondazz/KeyOverlay/pull/61#issuecomment-1560715941, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS77L2SBP47R3KUDWEVZR73XHXEJ3ANCNFSM6AAAAAAYCFAWF4 . You are receiving this because you authored the thread.Message ID: @.***>

Blondazz commented 1 year ago

Hi I'm the owner haha. Friedchicken repo is also forked. Fork is basically just creating a copy of the original code and based on the license that I set for the repo (GPL-3.0 license) you are free to do whatever you want with it after forking and I could use your solutions in my own code as well. So if you want it to be your own "version" then you are already set. If you have any other questions regarding github and git in general just hit me up on discord. Blondazz#4321

jekser2 commented 1 year ago

Thank you very much. Sorry for any inconvenience i made.

On Thu, May 25, 2023, 1:48 AM Daniel @.***> wrote:

Closed #61 https://github.com/Blondazz/KeyOverlay/pull/61.

— Reply to this email directly, view it on GitHub https://github.com/Blondazz/KeyOverlay/pull/61#event-9331509551, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS77L2VLY3ROJCZVKRKSETDXHZJV7ANCNFSM6AAAAAAYCFAWF4 . You are receiving this because you authored the thread.Message ID: @.***>