search

BloodHoundAD / BloodHound

Six Degrees of Domain Admin
GNU General Public License v3.0
9.56k stars 1.7k forks source link

Validation of JSON data format #601

Open rfc6919 opened 1 year ago

rfc6919 commented 1 year ago

Describe the bug

When additional data follows valid JSON in an upload file, the import hangs during the "Uploading data" stage.

To Reproduce

  1. Prepare a valid JSON data file to import, then append more stuff to the end of it (or be bitten by https://github.com/BloodHoundAD/AzureHound/issues/20)
  2. Upload the file to BloodHound
  3. Watch the "Uploading data" progress bar
  4. Wait for the progress bar to complete

Expected behavior

Either the upload errors out, or completes and either ignores the additional data or warns about it or something.

Additional context

Found as a result of azurehound producing json files that are malformed this way per https://github.com/BloodHoundAD/AzureHound/issues/20

rvazarkar commented 1 year ago

Neat issue, will take a look at how to fix this

JonasBK commented 1 year ago

The AzureHound issue has been solved. I will change this to an enhancement of the ingestion to verify that the JSON is not malformed.