search

BloodHoundAD / SharpHound2

The Old BloodHound C# Ingestor (Deprecated)
509 stars 113 forks source link

Fix ArgumentException on invalid SID #26

Closed Synse closed 6 years ago

Synse commented 6 years ago

These changes fix a System.ArgumentException in SidToDomainName when the SID is invalid.

This occurs when looking up foreign security principals with a name conflict. When this happens SharpHound will attempt to create a SecurityIdenifier from a string similar to S-1-5-21-123456789-123456789-123456789-123\0ACNF:aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee which will fail due to the invalid format.

rvazarkar commented 6 years ago

Looks like this got fixed as part of another commit. Thanks for the PR though!