search

BloodHoundAD / SharpHound2

The Old BloodHound C# Ingestor (Deprecated)
509 stars 113 forks source link

WIP: Persist the LDAP connection #30

Closed Meatballs1 closed 6 years ago

Meatballs1 commented 6 years ago

I have even left in my Conncetion typo

rvazarkar commented 6 years ago

I'm surprised this actually works. I was under the impression that the paging would get all sorts of messed up if you did this.

I'm going to do some testing with this to see if its workable

rvazarkar commented 6 years ago

Also, we have to make ldap connections to other domains, so this would definitely break that. Some work will have to be done to make sure that ldap connections for each domain are maintained, instead of just for one.

Meatballs1 commented 6 years ago

Yeah might need to be a bit cleverer if you are doing per domain. I would have thought the paging is per search however.

rvazarkar commented 6 years ago

Did you validate that you get the same amount of data with the connection caching?

Meatballs1 commented 6 years ago

Yes - but I was only doing 'Group' query rather than 'All'.

rvazarkar commented 6 years ago

Implemented in 2.0, thanks @Meatballs1