Throw ddl not found exception when missing SharpHoundRPC on init

definitelynotagoblin commented 5 months ago

Description

We want to exit SharpHound collection if SharpHoundRPC.dll is missing as we'd rather not support incomplete installations.

Motivation and Context

https://specterops.atlassian.net/browse/BP-316

How Has This Been Tested?

Install SharpHound to environment, remove SharpHoundRPC.dll, run SharpHound collection.

Screenshots (if appropriate):

Types of changes

[x] Chore (a change that does not modify the application functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Documentation updates are needed, and have been made accordingly.
[ ] I have added and/or updated tests to cover my changes.
[x] All new and existing tests passed.
[ ] My changes include a database migration.

definitelynotagoblin commented 5 months ago

Waiting on author for testing.

rvazarkar commented 4 months ago

I think we might want to move this logic to the clients instead of supporting it in CommonLib directly. Installation integrity should be handled there

BloodHoundAD / SharpHoundCommon