[BED-4342] Don't throw on Server Down (unless we want to) - Githubissues

BloodHoundAD / SharpHoundCommon

Common library used by SharpHound.

GNU General Public License v3.0

73 stars 47 forks source link

[BED-4342] Don't throw on Server Down (unless we want to) #119

Closed definitelynotagoblin closed 3 months ago

definitelynotagoblin commented 3 months ago

Description

LDAPQuery throws exception when a DC can't be reached after it's exhausted its retries, whether or not our throwException flag is set.

Motivation and Context

https://specterops.atlassian.net/browse/BP-642

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Chore (a change that does not modify the application functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Documentation updates are needed, and have been made accordingly.
[ ] I have added and/or updated tests to cover my changes.
[x] All new and existing tests passed.
[ ] My changes include a database migration.