BloodHoundAD / SharpHoundCommon

Common library used by SharpHound.
GNU General Public License v3.0
78 stars 47 forks source link

Fix for null sid values when resolving hosts to a sid #45

Closed mwstock closed 1 year ago

mwstock commented 1 year ago

SharpHound does not populate session information due to a null value being assigned as the SID in some cases. This appears to be due to one step in the ResolveHostToSid function where the ObjectIdentifier from the returned TypedPrincipal object is not assigned to the sid variable before being stored in the _hostResolutionMap dictionary. This fix should match the previous behaviour observed in SharpHound3.

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mwstock commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

rvazarkar commented 1 year ago

Thanks for the MR, will make it into the next version