search

BloodHoundAD / SharpHoundCommon

Common library used by SharpHound.
GNU General Public License v3.0
78 stars 47 forks source link

Local group fixes #49

Closed rvazarkar closed 1 year ago

rvazarkar commented 1 year ago

This fixes a bug where the incorrect sids were returned from URA and local group processing

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

rvazarkar commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

zinic commented 1 year ago

Tedious to test but it also makes it very clear what the issue was and how the changeset validates it. Looks like the automated tests are returning a non-zero status code despite none of the tests actually failing. Once that gets fixed up this looks good to me.

zinic commented 1 year ago

Additional changes have my :+1: