Fix CollectAllProperties flag and clean up reserved attributes - Githubissues

BloodHoundAD / SharpHoundCommon

Common library used by SharpHound.

GNU General Public License v3.0

77 stars 47 forks source link

Fix CollectAllProperties flag and clean up reserved attributes #67

Closed rvazarkar closed 1 year ago

rvazarkar commented 1 year ago

Description

The CollectAllProperties flag was not working at all due to the call to IsTextUnicode pretty much always returning false

Motivation and Context

https://github.com/BloodHoundAD/SharpHound/issues/56

How Has This Been Tested?

Tested locally in lab

Types of changes

[ ] Chore (a change that does not modify the application functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Documentation updates are needed, and have been made accordingly.
[ ] I have added and/or updated tests to cover my changes.
[x] All new and existing tests passed.
[ ] My changes include a database migration.