Bloodmallet / bloodmallet.github.io

Repository to share simulation data and visualize them via charts for all dps-specs in World of Warcraft
https://bloodmallet.com
GNU General Public License v3.0
17 stars 16 forks source link

Darkmoon Deck: Fathoms missing on 1/20/2019 #135

Closed zerlure closed 5 years ago

zerlure commented 5 years ago

I was trying to compare my current trinkets to the raid trinkets and the Darkmoon deck was pretty high before, but it appears to no longer be on the list.

Bloodmallet commented 5 years ago

What itemlevel does the item have or can be crafted at/upgraded to?

zerlure commented 5 years ago

355

Bloodmallet commented 5 years ago

That's the reason then. 370 is the lowest cutof now.

zerlure commented 5 years ago

Is that going to be changed, or that just the way it's going to be?

HawkCorrigan commented 5 years ago

shamelessly plugging a discord post

grafik

Bloodmallet commented 5 years ago

Adding some more context:

Bloodmallet(EU)Today at 14:18
it's actually quite hard to fit such exception in, without screwing every user ^^'
of course! please ask and suggest stuff
this helps to improve the resource
major issue with a "special itemlevel" is, it would either require me to add that itemlevel to everything or it would be misunderstood

The major problem with a trinket like this is: it either would need to appear in the legend and everyone would wonder why only one trinket has that itemlevel available and would want to have that itemlevel simed for everything. which is a calculation requirement I'd like to avoid. OR that item "looks" like a different itemlevel, but isn't. which would be even more confusing.

This item and the topic surrounding it is really difficult. I'd love have an easy solution but for now I can only leave it out. Calculation power is always a limiting factor.

zerlure commented 5 years ago

Thanks, I appreciate the well worded response. I just know that according to raidbots it's better than most 385 trinkets, was curious how it held up with 400. I'll just sim as I get new trinkets and figure it out myself.

Bloodmallet commented 5 years ago

Thank you for reaching out, and I'm sorry, that there isn't a solution to this issue for now. Hopefully this trinket becomes upgradeable, making it possible to add it back to the charts.

Raidbots is great!

nzall commented 5 years ago

What might be a solution is to have a "legacy" color. You might have this problem for the entire expansion, because from what I understand there were a couple of world boss trinkets that also simmed exceptionally well for some specs. Blizzard tends to be good at making most trinkets be similar DPS, but there are often a handful of items per expansion that have a particularly overpowered effect and eventually get nerfed because of it. I remember Draught of Souls and Convergence of Fates in Legion, Greatness in Wrath of the Lich King, most legendary weapons, Unerring Vision of Lei Shen in Mists of Pandaria, Dragonspine Trophy in TBC, Unheeded Warning in Cataclysm... Every expansion has a couple of these, so having a way to support exceptionally good trinkets from earlier tiers would be a good idea.

Bloodmallet commented 5 years ago

Going from a pure visual approach the "legacy" color makes sense. But that's not how the chart would actually work and show the data. These legacy trinkets would still show up with their appropriate itemlevel in the legend. Which would still create the same confusion. Or to play even more the devils advocate: What if next tier a 370 itemlevel trinket would need to stay in the chart as well. This would then probably force two legacy colors to ensure that the user knows that those two have different itemlevels.

I'd like to have a way to support special exceptions. I just don't know of a way right now. But maybe this discussion will polish for example your suggestion enough, so it'll see implementation. So please keep going with these ideas. We're just going through the process of improving them.

nzall commented 5 years ago

I see what you mean. What I mean is that legacy items would all have the same color regardless of itemlevel, and the itemlevel would be displayed inside the bar for that item to indicate that it doesn't follow the regular rules for itemlevels. So you have 1 legacy color, and that can be multiple itemlevels, and the legend would show Legacy* with a tooltip "check the graph for itemlevel information." Then any items that can't Warforge or Titanforge up to the minimum for the cutoff are shown in that color regardless of itemlevel and only show for their base itemlevel.