Bloodmallet / bloodytools

Bloodytools offer multiple different input generators for SimulationCraft. E.g. Trinkets, Races, Legendaries, Soulbinds, and Secondary Distributions....
https://bloodmallet.com/
GNU General Public License v3.0
13 stars 39 forks source link

paladin_retribution.yaml #133

Closed Eremiell27 closed 8 months ago

Eremiell27 commented 8 months ago

added m+ talent tree for target scaling

Bloodmallet commented 8 months ago

Thank you for the contribution. There are a few spelling errors in the talent names. I believe you meant:

M+:
   - class_talents=lay_on_hands:1/blessing_of_freedom:1/hammer_of_wrath:1/cleanse_toxins:1/auras_of_swift_vengeance:1/fist_of_justice:1/divine_steed:1/greater_judgment:1/blinding_light:1/cavalier:1/rebuke:1/holy_aegis:2/avenging_wrath:1/justification:1/blessing_of_sacrifice:1/sanctified_plates:2/blessing_of_protection:1/lightforged_blessing:1/healing_hands:1/unbreakable_spirit:1/crusaders_reprieve:1/seal_of_might:2/seal_of_alacrity:2/of_dusk_and_dawn:1/divine_toll:1/seal_of_the_crusader:2/seal_of_order:1/divine_resonance:1/vengeful_wrath:1
   - spec_talents=blade_of_justice:1/divine_storm:1/swift_justice:1/expurgation:1/improved_blade_of_justice:1/final_verdict:1/guided_prayer:1/art_of_war:1/jurisdiction:1/tempest_of_the_lightbringer:1/shield_of_vengeance:1/zealots_fervor:1/improved_judgment:1/crusading_strikes:1/blade_of_vengeance:1/vanguard_of_justice:1/avenging_wrath:1/blessed_champion:2/empyrean_power:1/adjudication:1/aegis_of_protection:1/penitence:1/blades_of_light:1/final_reckoning:1/wake_of_ashes:1/burning_crusade:1/seething_flames:1/truths_wake:1/searing_light:1

apart fromt hat I still get an error with avenging_wrath. I need to look into this one further and will get back to you when I know more.

Bloodmallet commented 8 months ago

Gastank was so kind and figured it out. The talent in the spec tree is called "Avenging Wrath: Might", and the talent there needs to match that name. like so:

M+:
   - class_talents=lay_on_hands:1/blessing_of_freedom:1/hammer_of_wrath:1/cleanse_toxins:1/auras_of_swift_vengeance:1/fist_of_justice:1/divine_steed:1/greater_judgment:1/blinding_light:1/cavalier:1/rebuke:1/holy_aegis:2/avenging_wrath:1/justification:1/blessing_of_sacrifice:1/sanctified_plates:2/blessing_of_protection:1/lightforged_blessing:1/healing_hands:1/unbreakable_spirit:1/crusaders_reprieve:1/seal_of_might:2/seal_of_alacrity:2/of_dusk_and_dawn:1/divine_toll:1/seal_of_the_crusader:2/seal_of_order:1/divine_resonance:1/vengeful_wrath:1
   - spec_talents=blade_of_justice:1/divine_storm:1/swift_justice:1/expurgation:1/improved_blade_of_justice:1/final_verdict:1/guided_prayer:1/art_of_war:1/jurisdiction:1/tempest_of_the_lightbringer:1/shield_of_vengeance:1/zealots_fervor:1/improved_judgment:1/crusading_strikes:1/blade_of_vengeance:1/vanguard_of_justice:1/avenging_wrath_might:1/blessed_champion:2/empyrean_power:1/adjudication:1/aegis_of_protection:1/penitence:1/blades_of_light:1/final_reckoning:1/wake_of_ashes:1/burning_crusade:1/seething_flames:1/truths_wake:1/searing_light:1

do you want to update your pr, or do youw ant me to add it directly?

Eremiell27 commented 8 months ago

Hello, thank you for contacting me and sorry for the spelling error and the error with Avenging Wrath: Might. I was going to send you export from the game: BYEAomTTpSA9oX6huYLb5nP3rDAAAQAgIo0KJtSTiikkikAAAAAAAphDkkQgkIRKRgQkSSpFJIEoUoBAA but as you already fix the issue is ok if you add it directly.

Thank you Roman

On Mon, 5 Feb 2024 at 19:32, BloodmalletEU @.***> wrote:

Gastank was so kind and figured it out. The talent in the spec tree is called "Avenging Wrath: Might", and the talent there needs to match that name. like so:

M+:

  • class_talents=lay_on_hands:1/blessing_of_freedom:1/hammer_of_wrath:1/cleanse_toxins:1/auras_of_swift_vengeance:1/fist_of_justice:1/divine_steed:1/greater_judgment:1/blinding_light:1/cavalier:1/rebuke:1/holy_aegis:2/avenging_wrath:1/justification:1/blessing_of_sacrifice:1/sanctified_plates:2/blessing_of_protection:1/lightforged_blessing:1/healing_hands:1/unbreakable_spirit:1/crusaders_reprieve:1/seal_of_might:2/seal_of_alacrity:2/of_dusk_and_dawn:1/divine_toll:1/seal_of_the_crusader:2/seal_of_order:1/divine_resonance:1/vengeful_wrath:1
  • spec_talents=blade_of_justice:1/divine_storm:1/swift_justice:1/expurgation:1/improved_blade_of_justice:1/final_verdict:1/guided_prayer:1/art_of_war:1/jurisdiction:1/tempest_of_the_lightbringer:1/shield_of_vengeance:1/zealots_fervor:1/improved_judgment:1/crusading_strikes:1/blade_of_vengeance:1/vanguard_of_justice:1/avenging_wrath_might:1/blessed_champion:2/empyrean_power:1/adjudication:1/aegis_of_protection:1/penitence:1/blades_of_light:1/final_reckoning:1/wake_of_ashes:1/burning_crusade:1/seething_flames:1/truths_wake:1/searing_light:1

do you want to update your pr, or do youw ant me to add it directly?

— Reply to this email directly, view it on GitHub https://github.com/Bloodmallet/bloodytools/pull/133#issuecomment-1927752492, or unsubscribe https://github.com/notifications/unsubscribe-auth/BE7E75L7BHYY547EZXJKROLYSEQULAVCNFSM6AAAAABCZFVZMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXG42TENBZGI . You are receiving this because you authored the thread.Message ID: @.***>

Bloodmallet commented 8 months ago

Alright, I added it directly. I'm closing this pr. Thank you for reaching out!