Bloodmallet / bloodytools

Bloodytools offer multiple different input generators for SimulationCraft. E.g. Trinkets, Races, Legendaries, Soulbinds, and Secondary Distributions....
https://bloodmallet.com/
GNU General Public License v3.0
13 stars 39 forks source link

Bloodytooling saved simc profiles fails at talents #6

Closed choseh closed 6 years ago

choseh commented 6 years ago

2018-09-14 22:34:48,846 - ERROR - ERROR: An Error occured during simulation. 2018-09-14 22:34:48,846 - ERROR - args: ['../../simulationcraft/engine/simc', 'b9086eb8-e1dd-4c3e-9836-45180b42de3c.simc'] 2018-09-14 22:34:48,846 - ERROR - stdout: SimulationCraft 801-02 for World of Warcraft 8.0.1 Live (wow build 27602, git build bfa-dev 6db2df0)

Player Arthine has malformed talent url 'https://worldofwarcraft.com/en-gb/game/talent-calculator#rogue/assassination/' Error: Unknown option 'talents' with value 'https://worldofwarcraft.com/en-gb/game/talent-calculator#rogue/assassination/'.

2018-09-14 22:34:48,846 - ERROR - name=value error? Check your input! Maybe your links to already existing profiles are wrong. They need to be relative links from bloodytools to your SimulationCraft directory. 2018-09-14 22:34:48,846 - ERROR - Secondary distribution simulation for rogue assassination https://worldofwarcraft.com/en-gb/game/talent-calculator#rogue/assassination/ failed. SimulationCraft 801-02 for World of Warcraft 8.0.1 Live (wow build 27602, git build bfa-dev 6db2df0)

Player Arthine has malformed talent url 'https://worldofwarcraft.com/en-gb/game/talent-calculator#rogue/assassination/' Error: Unknown option 'talents' with value 'https://worldofwarcraft.com/en-gb/game/talent-calculator#rogue/assassination/'.

choseh commented 6 years ago

talents=https://worldofwarcraft.com/en-gb/game/talent-calculator#rogue/assassination/talents=2212321

is the actual value of that var in the .simc file

choseh commented 6 years ago

steps to reproduce:

  1. ./simc armory=eu,azshara,arthine save=./profiles/arthine.simc apikey=yourapikey
  2. copy arthine.simc to profiles/Tier22/T22_Rogue_Assassination.simc
  3. run bloodytools
  4. wait
  5. gaze at error
Bloodmallet commented 6 years ago

Thank you for the report, I'll dive into it

Bloodmallet commented 6 years ago

Issue should be fixed with the above commit.